-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zha ikea starkvind capabilities and modes being incorrectly exposed #114854
Conversation
Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Nice, thanks! I plan to test both your PRs soon. |
@TheJulianJES Heyy any update? This fix whould be amazing |
Now that zigpy/zha-device-handlers#3088 is merged I rebased this on |
…posed Fixes home-assistant#97440 Previously starkvind exposed 10 speed settings and no modes, where 10% corresponded to auto mode and 20%-100% corresponded to fixed speeds. This patch correctly exposes auto mode as a mode. It also adds support for showing the actual fan speed while auto mode is enabled. Starkvind supports 9 fan speeds. Because 9 doesn't neatly fit into 100% I cheated a bit and divided the 100% into 10% increments, where trying to set the fan to 10% sets it to 20% instead. I believe that this gives the overall better user experience compared to having 11.11% increments. The 5 speed modes present on the physical interface of the device correspond to HA speed settings 20%, 40%, 60% and 100%. This patch depends on zigpy/zha-device-handlers#3088 being merged and released.
@TheJulianJES Any update on when this might get reviewed? |
Haven't forgotten about this. There'll be some major ZHA changes coming and to avoid conflicts for now, we'll try to get that finished first (hopefully for the August release). |
I'm marking this PR as a draft while we are waiting for those larger changes to happen. This helps us clearing/getting a better overview of the review queue. ../Frenck |
We have recently migrated the core of ZHA to its own library. Please open a pull request here: https://github.com/zigpy/zha for this. Sorry for the inconvenience and Thanks! |
I'll try to find some time to rebase this next week. I guess the changes have been big enough that I should retest and adjust this? |
Fixes #97440.
Previously starkvind exposed 10 speed settings and no modes, where 10% corresponded to auto mode and 20%-100% corresponded to fixed speeds.
Proposed change
This patch correctly exposes auto mode as a mode. It also adds support for showing the actual fan speed while auto mode is enabled.
Starkvind supports 9 fan speeds. Because 9 doesn't neatly fit into 100% I cheated a bit and divided the 100% into 10% increments, where trying to set the fan to 10% sets it to 20% instead. I believe that this gives the overall better user experience compared to having 11.11% increments. The 5 speed modes present on the physical interface of the device correspond to HA speed settings 20%, 40%, 60% and 100%.
This patch depends on zigpy/zha-device-handlers#3088 being merged and released.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: